On Wed, Jun 15, 2011 at 12:32, Julian Foad <julian.foad_at_wandisco.com> wrote:
> On Fri, 2011-06-10 at 09:06 +0100, Julian Foad wrote:
>> I (Julian Foad) wrote:
>> > On Thu, 2011-06-09, I (Julian Foad) wrote:
>> > > svn_dirent_uri.h
>> > > svn_relpath_internal_style()
>> > > svn_relpath_local_style()
>> > > # These two are inappropriate: only dirents have a 'local' style.
>> >
>> > I removed the former and made the latter private in r1133964.
>
> Bert pointed out that there is a desire and precedent for the Windows
> client to display in-repository relpaths using the Windows "\"
> separator, so svn_relpath_local_style() may be wanted. It was currently
URLs use forward slashes. Backslashes are not proper separators. The
above does not make sense.
>...
> Many callers of svn_dirent_skip_ancestor(), on the other hand, expect
> the 'child' input to be returned if it is not in fact a child. I am
> splitting the function into two:
>
> svn_dirent_skip_ancestor() - return NULL if not a child
> [some other function name] - return 'child' input if not a child
PLEASE not another function. There are already too many variants of
the same thing:
svn_dirent_is_child()
svn_dirent_skip_ancestor()
svn_dirent_is_ancestor()
These are all trivial variants which leads the reader to say "umm...
which one is this?" and the developer to say "umm... which do I use
here?". Please do not add a fourth... it will only exacerbate an
already awful situation.
If anything, please reduce the number to ONE.
Cheers,
-g
Received on 2011-06-15 18:43:00 CEST