[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: API change - make svn_tristate_to_word/_from_word() private?

From: Greg Stein <gstein_at_gmail.com>
Date: Wed, 15 Jun 2011 12:52:06 -0400

On Wed, Jun 15, 2011 at 10:14, Julian Foad <julian.foad_at_wandisco.com> wrote:
> New in 1.7 in svn_types.h:
>  svn_tristate_t
>  svn_tristate_to_word()  # yields "true"/"false"/NULL
>  svn_tristate_from_word()  # takes "true"/"yes"/"on"/.../
> At least, and at first, we should remove the second and third usages
> listed above.  Those usages are more akin to "svn_cmdline" or
> "svn_config" utilities, or could well be private.
> Further, I consider moving/renaming these two functions to be a bit more
> private even for their main use in svn_log_changed_path2_t.

Concur. Those things always made me a little hinky.

Received on 2011-06-15 18:52:38 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.