[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1124375 - in /subversion/trunk/subversion: libsvn_client/checkout.c libsvn_wc/upgrade.c

From: Julian Foad <julian.foad_at_wandisco.com>
Date: Thu, 19 May 2011 10:36:25 +0200

Stefan, please could you put those explanations in the log message?

- Julian

On Thu, 2011-05-19 at 08:35 +0200, C. Michael Pilato wrote:
> On 05/19/2011 08:11 AM, Stefan Küng wrote:
> >> Hrm. I rather expected that this change would have two components:
> >>
> >> 1. Remove references to 'svn' subcommands from share lib error messages.
> >> 2. From the same places, return unique-enough error codes that the client
> >> catches so *it* can give those same client-specific suggestions.
> >>
> >> Looks like only step #1 was done here. Were you intending to take this further?
> >
> > In checkout.c, I'm pretty sure an update doesn't help: why would an
> > update do anything good in case of a failed checkout because a folder
> > is already a working copy for a different url? IMHO that update hint
> > was wrong in the first place. --> an update does not change the fact
> > that there's a working copy from another repo in the way.
> >
> > In upgrade.c, a different error code won't help since the cleanup has
> > to be done with an 1.6 client (i.e., a client with an older version).
> > So a client simply can not act on this and do the cleanup itself.
>
> Thanks for the explanation of your reasoning. I concur.
>
Received on 2011-05-19 10:37:03 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.