Re: [PATCH in progress] Pristine text store - pristine_install

On Fri, 2011-02-18 at 16:01 +0100, Branko Čibej wrote:
> On 18.02.2011 15:49, Julian Foad wrote:
> > svn_error_t *
> > +svn_sqlite__with_immediate_transaction(svn_sqlite__db_t *db,
> > + svn_sqlite__transaction_callback_t cb_func,
> > + void *cb_baton,
> > + apr_pool_t *scratch_pool /* NULL allowed */)
> > +{
>
> So you created a new (private) function that's a copy-paste of another
> (private) function, both of which are new on trunk, and the difference
> between them are in one line of the function body.
>
> What's wrong with that picture?

Ok OK! You caught me. Normally I consider myself the last person who
would duplicate code. I'll certainly un-duplicate before commit.

Any comments on functionality? (I do appreciate you keeping an eye on
style, duplication etc. too though.)

- Julian
Received on 2011-02-18 16:52:16 CET