[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH in progress] Pristine text store - pristine_install

From: Branko Čibej <brane_at_e-reka.si>
Date: Fri, 18 Feb 2011 16:01:44 +0100

On 18.02.2011 15:49, Julian Foad wrote:
> svn_error_t *
> +svn_sqlite__with_immediate_transaction(svn_sqlite__db_t *db,
> + svn_sqlite__transaction_callback_t cb_func,
> + void *cb_baton,
> + apr_pool_t *scratch_pool /* NULL allowed */)
> +{

So you created a new (private) function that's a copy-paste of another
(private) function, both of which are new on trunk, and the difference
between them are in one line of the function body.

What's wrong with that picture?

-- Brane
Received on 2011-02-18 16:03:48 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.