[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1053932 - /subversion/trunk/subversion/bindings/javahl/tests/org/apache/subversion/javahl/BasicTests.java

From: Blair Zajac <blair_at_orcaware.com>
Date: Thu, 30 Dec 2010 11:24:16 -0800

On 12/30/10 8:33 AM, markphip_at_apache.org wrote:
> Author: markphip
> Date: Thu Dec 30 16:32:59 2010
> New Revision: 1053932
>
> URL: http://svn.apache.org/viewvc?rev=1053932&view=rev
> Log:
> JavaHL: Followup to r1053915.
> Update the properties test to set and get a property with binary data.
>
> * subversion/bindings/javahl/tests/org/apache/subversion/javahl/BasicTests.java
> (testBasicProperties): Set the property value with binary data instead of a String
> Also update other caller in same test to use the new Byte[] method with a String

> wc.setItemPropStatus("iota", Status.Kind.modified);
> thisTest.checkStatus();
> @@ -705,7 +708,8 @@ public class BasicTests extends SVNTests
> itemPath = fileToSVNPath(new File(thisTest.getWCPath(),
> "/A/B/E/alpha"),
> false);
> - client.propertyCreate(itemPath, "cqcq", "qrz", Depth.empty, null,
> + String alphaVal = "qrz";
> + client.propertyCreate(itemPath, "cqcq", alphaVal.getBytes(), Depth.empty, null,

Do you need to pass "UTF-8" to alphaVal.getBytes?

> false, null);
>
> final Map<String, Map<String, byte[]>> propMaps =
> @@ -719,7 +723,7 @@ public class BasicTests extends SVNTests
> for (String key : propMap.keySet())
> {
> assertEquals("cqcq", key);
> - assertEquals("qrz", new String(propMap.get(key)));
> + assertEquals(alphaVal, new String(propMap.get(key)));

And here to the String constructor?

Blair
Received on 2010-12-30 20:24:54 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.