Re: Any idea why public function like "svn_fspath__dirname" have double "__" in its name?

On 12/28/2010 04:30 AM, Kamesh Jayachandran wrote:
> Hi All,
>
> I could see the following functions in our public header with '__' in their
> names,
>
> svn_fspath__is_canonical
> svn_fspath__dirname
> svn_fspath__basename
> svn_fspath__split
> svn_fspath__join
> svn_fspath__is_child
> svn_fspath__skip_ancestor
> svn_fspath__is_ancestor
> svn_fspath__get_longest_ancestor
> svn_error__locate
>
> svn_error__malfunction
>
> IIUC "__" convention is used for semi-public functions where we may not keep
> BC promise.
>
> Do I miss something?

While we've mandated that "__" must be used for semi-public functions, we've
never said that it can't be used for private ones. One could argue that the
use of "__" for even private functions avoids a required rename if the
function is made semi-public, and adds information. For example, I know
that most of the functions you list above are FS-related and probably
logically related. But I wouldn't suggest a universal policy change at this
stage.

-- 
C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand