[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Any idea why public function like "svn_fspath__dirname" have double "__" in its name?

From: Peter Samuelson <peter_at_p12n.org>
Date: Tue, 28 Dec 2010 16:13:04 -0600

[C. Michael Pilato]
> > svn_fspath__is_canonical
> > svn_fspath__dirname
> > svn_fspath__basename
> > svn_fspath__split
> > svn_fspath__join
> > svn_fspath__is_child
> > svn_fspath__skip_ancestor
> > svn_fspath__is_ancestor
> > svn_fspath__get_longest_ancestor
> > svn_error__locate
> >
> > svn_error__malfunction

> While we've mandated that "__" must be used for semi-public
> functions, we've never said that it can't be used for private ones.

Kamesh is talking about public, not private, functions. I.e., ones
where we actually do have an ABI promise to keep.

I looked at svn_error__locate last week. It's really only useful in
--enable-maintainer-mode, but the way it's implemented, it ends up
being used by macros in the public (non-maintainer) ABI, so even if we
eliminate those callers, we have to supply the function itself forever.
I've addressed this as best we can, in r1053469.

Supplying a given ABI forever is the sort of thing I thought we didn't
have to do for __ functions. I think that's Kamesh's question too.

Peter Samuelson | org-tld!p12n!peter | http://p12n.org/
Received on 2010-12-28 23:13:55 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.