Re: [PATCH] fixes some path related deprecation warnings

Prabhu

--- subversion/libsvn_repos/commit.c (revision 1053267)
+++ subversion/libsvn_repos/commit.c (working copy)
@@ -231,7 +231,7 @@
    svn_node_kind_t kind;
    svn_revnum_t cr_rev;
    svn_repos_authz_access_t required = svn_authz_write;
- const char *full_path = svn_path_join(eb->base_path, path, pool);
>+ const char *full_path = svn_dirent_join(eb->base_path, path, pool);

I think you need to use svn_fspath__join

Same in other parts of this patch.

Because eb->basepath is a path inside fs as per the below snipped comment.

<snip>
   /* Location in fs where the edit will begin. */
   const char *base_path;
</snip>

With regards
Kamesh Jayachandran
Received on 2010-12-28 15:44:16 CET