[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: [PATCH] Use neon's system proxy detection if not explicitly specified

From: Dominique Leuenberger <dominique_at_leuenberger.net>
Date: Mon, 27 Sep 2010 14:48:20 +0200

On Mon, 2010-09-27 at 13:19 +0100, Jon Foster wrote:

> Better, but it'll still go wrong with Neon 0.40 or 1.00. I guess it
> needs to be something like:
>
> if test -n ["`echo "$NEON_VERSION" | $EGREP
> '^(([1-9][0-9]*)|(0\.(29|[3-9][0-9])))\.'`"] ; then
>
> ? That should match 0.29-0.99 and 1.0 or later. I'm assuming there
> won't ever be a 0.100 release.
>

Right; the up to 0.39 check is a lazy copy paste from all the other
check in neon.m4 :)

The check which exists already for 0.28 is like this:
      if test -n ["`echo "$NEON_VERSION" | $EGREP '^0\.(2[8-9]|
3[0-9])\.'`"] ; then
        AC_DEFINE_UNQUOTED([SVN_NEON_0_28], [1],
                           [Define to 1 if you have Neon 0.28 or
later.])
      fi

For me either way is fine: I can update the patch to also detect newer
versions as suggest by you. Which in turn will still break all the other
detections of SVN_NEON_0_28 and older. Or we keep them 'in sync'
together and fix them all together at a later stage.

> (Aside: This would be much easier if neon #defined a macro like
> NE_VERSION_NUMBER, which we could just test in an #ifdef.
> Unfortunately, it doesn't seem to have one).

Indeed. This was actually what took me most of the time to find out how
the heck do you guys know what version neon has :) until I found
neon.m4.

Dominique
Received on 2010-09-27 14:46:01 CEST

This is an archived mail posted to the Subversion Dev mailing list.