[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: [PATCH] Use neon's system proxy detection if not explicitly specified

From: Jon Foster <Jon.Foster_at_cabot.co.uk>
Date: Mon, 27 Sep 2010 13:19:00 +0100

Dominique Leuenberger wrote:
> On Mon, 2010-09-27 at 12:33 +0100, Jon Foster wrote:
> > Hi,
> >
> > + if test -n ["`echo "$NEON_VERSION" | grep '^0\.29\.'`"] ; then
> > + AC_DEFINE_UNQUOTED([SVN_NEON_0_29], [1],
> > + [Define to 1 if you have Neon 0.29 or later.])
> > + fi
> >
> > The comment says "0.29 or later" (which I think is right), but
> > the test looks like it's checking for Neon 0.29 exactly. Will
> > this go wrong with Neon 0.30 or 1.00?
>
> Hi,
>
> That's the patch for 1.6.12 as I remember.

Yes. I hadn't realised they did this test differently, sorry.

> It is rather unclear if neon 0.30 is going to change API or
> not to me. I would assume not.

If it changes the API, the build might break whatever you do.
So it's probably best to assume that it doesn't change API.
(Also: API changes usually cause the build to explode; this
test failing will just quietly disable a feature).

> This is also the reason why the trunk based patch contains:
>
> + if test -n ["`echo "$NEON_VERSION" | $EGREP '^0\.(29|
> 3[0-9])\.'`"] ; then
> + AC_DEFINE_UNQUOTED([SVN_NEON_0_29], [1],
> + [Define to 1 if you have Neon 0.29 or
> later.])
> + fi
> +
>
> This should trigger at least 0.3x as valid as well. (the 1.6.12 patch
is
> more for reference, as that is the tested one).

Better, but it'll still go wrong with Neon 0.40 or 1.00. I guess it
needs to be something like:

if test -n ["`echo "$NEON_VERSION" | $EGREP
    '^(([1-9][0-9]*)|(0\.(29|[3-9][0-9])))\.'`"] ; then

? That should match 0.29-0.99 and 1.0 or later. I'm assuming there
won't ever be a 0.100 release.

(Aside: This would be much easier if neon #defined a macro like
NE_VERSION_NUMBER, which we could just test in an #ifdef.
Unfortunately, it doesn't seem to have one).

Kind regards,

Jon

**********************************************************************
This email and its attachments may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of Cabot Communications Ltd.

If you are not the intended recipient of this email and its attachments, you must take no action based upon them, nor must you copy or show them to anyone.

Cabot Communications Limited
Verona House, Filwood Road, Bristol BS16 3RY, UK
+44 (0) 1179584232

Co. Registered in England number 02817269

Please contact the sender if you believe you have received this email in error.

**********************************************************************

______________________________________________________________________
This email has been scanned by the MessageLabs Email Security System.
For more information please visit http://www.messagelabs.com/email
______________________________________________________________________
Received on 2010-09-27 14:19:43 CEST

This is an archived mail posted to the Subversion Dev mailing list.