[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: [PATCH] Use neon's system proxy detection if not explicitly specified

From: Dominique Leuenberger <dominique_at_leuenberger.net>
Date: Wed, 29 Sep 2010 12:22:56 +0200

On Mon, 2010-09-27 at 13:19 +0100, Jon Foster wrote:
> Better, but it'll still go wrong with Neon 0.40 or 1.00. I guess it
> needs to be something like:
> if test -n ["`echo "$NEON_VERSION" | $EGREP
> '^(([1-9][0-9]*)|(0\.(29|[3-9][0-9])))\.'`"] ; then
> ? That should match 0.29-0.99 and 1.0 or later. I'm assuming there
> won't ever be a 0.100 release.

As my last mail did remain unanswered and I don't want to have the whole
thread go lost; here re-replied:

The current check for 0.29/0.3x is copied from the other checks for
NEON_0_2(<9). I think it would not be wrong to keep the checks in sync
(or optionally even restructure this test with nested ifs).

For me either way is fine: I can update the patch to also detect newer
versions as suggest by you. Which in turn will still break all the other
detections of SVN_NEON_0_28 and older. Or we keep them 'in sync'
together and fix them all together at a later stage.

Best regards,
Received on 2010-09-29 12:20:35 CEST

This is an archived mail posted to the Subversion Dev mailing list.