[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1000370 - /subversion/trunk/subversion/libsvn_wc/wc-queries.sql

From: Greg Stein <gstein_at_gmail.com>
Date: Thu, 23 Sep 2010 13:32:59 -0400

On Thu, Sep 23, 2010 at 05:16, <philip_at_apache.org> wrote:
> Author: philip
> Date: Thu Sep 23 09:16:28 2010
> New Revision: 1000370
>
> URL: http://svn.apache.org/viewvc?rev=1000370&view=rev
> Log:
> Use lower case in SQL queries instead of mixing upper and lower
> cases inconsistently.  No functional change.

I preferred the form with uppercase keywords and table names. It makes
it much easier to see which columns are selected, and to read the
expressions in WHERE clauses.

IOW, I disagree with this change and would actually prefer fixing the
all-lowercase queries that were scattered around.

>...

Cheers,
-g
Received on 2010-09-23 19:33:36 CEST

This is an archived mail posted to the Subversion Dev mailing list.