[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1000495 - /subversion/trunk/subversion/libsvn_wc/wc_db.c

From: Julian Foad <julian.foad_at_wandisco.com>
Date: Thu, 23 Sep 2010 18:34:10 +0100

Greg Stein wrote:
> On Thu, Sep 23, 2010 at 11:22, <julianfoad_at_apache.org> wrote:
> >...
> > +++ subversion/trunk/subversion/libsvn_wc/wc_db.c Thu Sep 23 15:22:52 2010
> >...
> > @@ -3665,7 +3665,7 @@ svn_wc__db_op_copy(svn_wc__db_t *db,
> > SVN_ERR(svn_sqlite__bindf(stmt, "issisnnnt",
> > src_pdh->wcroot->wc_id, src_relpath,
> > dst_relpath,
> > - (children == NULL) ? (apr_int64_t)2 :
> > + (children == NULL) ? (apr_int64_t)2 : /* ### op_depth */
> > (apr_int64_t)1, /* no directory or stub */
>
> I see stuff like this scattered all through wc_db. How can we possibly
> use constants for op_depth? Those constants only make sense in
> multi-db. Shouldn't these be switched to look at the path now?

Yes, precisely. That's what I'm doing now, and why I've been trying to
understand the NODES design properly for the last ten days.

- Julian
Received on 2010-09-23 19:35:08 CEST

This is an archived mail posted to the Subversion Dev mailing list.