[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1000495 - /subversion/trunk/subversion/libsvn_wc/wc_db.c

From: Philip Martin <philip.martin_at_wandisco.com>
Date: Thu, 23 Sep 2010 18:32:24 +0100

Greg Stein <gstein_at_gmail.com> writes:

> On Thu, Sep 23, 2010 at 11:22, <julianfoad_at_apache.org> wrote:
>>...
>> +++ subversion/trunk/subversion/libsvn_wc/wc_db.c Thu Sep 23 15:22:52 2010
>>...
>> @@ -3665,7 +3665,7 @@ svn_wc__db_op_copy(svn_wc__db_t *db,
>>       SVN_ERR(svn_sqlite__bindf(stmt, "issisnnnt",
>>                     src_pdh->wcroot->wc_id, src_relpath,
>>                     dst_relpath,
>> -                    (children == NULL) ? (apr_int64_t)2 :
>> +                    (children == NULL) ? (apr_int64_t)2 :  /* ### op_depth */
>>                                 (apr_int64_t)1, /* no directory or stub */
>
> I see stuff like this scattered all through wc_db. How can we possibly
> use constants for op_depth? Those constants only make sense in
> multi-db. Shouldn't these be switched to look at the path now?

op_depth is not implemented yet beyond zero/non-zero. We could change
all those lines to a simple (apr_int64_t)1. There is one advantage to
making some of them 1 and some of them 2: it means we can't
accidentally rely on the value being 1.

-- 
Philip
Received on 2010-09-23 19:33:07 CEST

This is an archived mail posted to the Subversion Dev mailing list.