[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] Add a '--fsfs-no-repsharing' flag to svnadmin

From: Simon Atanasyan <simon_at_visualsvn.com>
Date: Tue, 20 Jul 2010 18:32:47 +0400

The general idea of the patch is to introduce new svnadmin option
and FSFS filesystem configuration option to allow enabling/disabling
repository sharing on FSFS.

I am not sure that SQLite locking works correctly over network share
due the limit file level locking support offered by OS for network shares.
SQLite is used for repository sharing so it may lead to repository corruption.
svnadmin and filesystem configuration options help users control this issue.

The log message is as follows:
Add a '--fsfs-no-repsharing' flag to svnadmin to allow enable/disable
repository sharing on FSFS.

* subversion\svnadmin\main.c
 (svnadmin__fsfs_no_rep_sharing): New long option identifier.
 (options_table): Define '--fsfs-no-repsharing'.
 (cmd_table): Add '--fsfs-no-repsharing' to the list
  of options for 'svnadmin create'.
 (svnadmin_opt_state): Add member 'fsfs_no_rep_sharing'.
 (subcommand_create): Set the value of the 'SVN_FS_CONFIG_FSFS_REP_SHARING'
  config option in the 'fs_config' cache.
 (main): Handle the '--fsfs-no-repsharing' option.

* subversion\include\svn_fs.h
 (SVN_FS_CONFIG_FSFS_REP_SHARING): New filesystem configuration option.

* subversion\libsvn_fs_fs\fs_fs.c
 (write_config): Use value of 'SVN_FS_CONFIG_FSFS_REP_SHARING' config option
  while writing FSFS filesystem configuration file.

* tools\client-side\bash_completion
 (_svnadmin): Add '--fsfs-no-repsharing'.

The patch itself is in the attachment.

Best regards,
Simon Atanasyan
VisualSVN Limited
Received on 2010-07-20 16:35:50 CEST

This is an archived mail posted to the Subversion Dev mailing list.