Re: [PATCH] Add a '--fsfs-no-repsharing' flag to svnadmin

Simon Atanasyan <simon_at_visualsvn.com> writes:

> The general idea of the patch is to introduce new svnadmin option
> and FSFS filesystem configuration option to allow enabling/disabling
> repository sharing on FSFS.
>
> I am not sure that SQLite locking works correctly over network share
> due the limit file level locking support offered by OS for network shares.
> SQLite is used for repository sharing so it may lead to repository corruption.
> svnadmin and filesystem configuration options help users control this issue.

Is this a patch for trunk or 1.6? In 1.7 SQLite is used for revprop
packing as well. If SQLite is unreliable on network filesystems we
would need to disable that as well. Perhaps an --fsfs-no-sqlite
option?

> The log message is as follows:
> [[[
> Add a '--fsfs-no-repsharing' flag to svnadmin to allow enable/disable
> repository sharing on FSFS.
>
> * subversion\svnadmin\main.c
> (svnadmin__fsfs_no_rep_sharing): New long option identifier.
> (options_table): Define '--fsfs-no-repsharing'.
> (cmd_table): Add '--fsfs-no-repsharing' to the list
> of options for 'svnadmin create'.
> (svnadmin_opt_state): Add member 'fsfs_no_rep_sharing'.
> (subcommand_create): Set the value of the 'SVN_FS_CONFIG_FSFS_REP_SHARING'
> config option in the 'fs_config' cache.
> (main): Handle the '--fsfs-no-repsharing' option.
>
> * subversion\include\svn_fs.h
> (SVN_FS_CONFIG_FSFS_REP_SHARING): New filesystem configuration option.
>
> * subversion\libsvn_fs_fs\fs_fs.c
> (write_config): Use value of 'SVN_FS_CONFIG_FSFS_REP_SHARING' config option
> while writing FSFS filesystem configuration file.
>
> * tools\client-side\bash_completion
> (_svnadmin): Add '--fsfs-no-repsharing'.
> ]]]
>
> The patch itself is in the attachment.

I see no attachment.

-- 
Philip