Re: svn_client_patch not applying patch correctly

On Fri, May 21, 2010 at 10:27:42PM +0200, Stefan Küng wrote:
> * ShellCache.h
> -> this file results in three applied and one rejected hunk
> the result as it *should* be is shown in image1, the result
> from svn_client_patch is shown in image2

Where are the images you are referring to?

This seems to be a "no newline at end of file" handling problem.
We should look at it in detail. Please file an issue.

> * file1
> -> this empty file should get one new line added, but instead
> that hunk is rejected and the file stays empty.

This is a bug in svn patch. Looks like it assumes the file will have content
since it already exists (albeit it is empty). Please file a separate
issue for this.

Thanks,
Stefan
Received on 2010-05-22 00:59:15 CEST