[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH - v3] readable error messages on non-ASCII systems

From: Greg Ames <ames.greg_at_gmail.com>
Date: Thu, 20 May 2010 15:10:04 -0400

This isn't going to do the whole job, nor is patch #2. If I grep for
'svn_cmdline_printf.*\"' to find where native literal strings are passed to
svn_cmdline_printf, I get 130 hits in trunk, for example:

./subversion/svn/util.c: SVN_ERR(svn_cmdline_printf(pool, _("\nWarning:
%s\n"),
./subversion/svn/proplist-cmd.c: SVN_ERR(svn_cmdline_printf(pool,
_("Properties on '%s':\n"), name_local));

So it's not just error messages that are a problem on z/OS. Digging deeper,
I see that the svn ctype functions are hardwired to ASCII. If they called
the equivalent apr ctype functions instead, they should become portable to
EBCDIC. Doing that should change the behavior of
svn_utf__cstring_from_utf8_fuzzy() and produce readable normal messages as
well as the error messages.

Greg

On Tue, May 18, 2010 at 6:14 PM, Greg Ames <ames.greg_at_gmail.com> wrote:

> This version hits error.c only, no new APIs. Sending as an attachment per
> http://subversion.apache.org/docs/community-guide/general.html#patches
>
> [[[ Produce readable error messages on non-ASCII systems.
>
> * subversion/libsvn_subr/error.c:
> print_error(): convert err->message and the message prefix to UTF-8
> before calling svn_cmdline_printf.
> svn_error_wrap_apr(): remove UTF-8 conversion of apr_strerror output
> before storing it in err->message to avoid a double conversion
> ]]]
>
> Greg
>
>
>
Received on 2010-05-20 21:10:32 CEST

This is an archived mail posted to the Subversion Dev mailing list.