Re: [PATCH - v3] readable error messages on non-ASCII systems

On Thu, May 20, 2010 at 03:10:04PM -0400, Greg Ames wrote:
> I see that the svn ctype functions are hardwired to ASCII. If they called
> the equivalent apr ctype functions instead, they should become portable to
> EBCDIC. Doing that should change the behavior of
> svn_utf__cstring_from_utf8_fuzzy() and produce readable normal messages as
> well as the error messages.

Have you tried tweaking svn_ctype.h to use the ctype functions from APR?
Does that fix your problem?

If it helps we could either discard the custom ctype implementation
(I don't really see a need for svn to have its own ctype implementation),
or at least use the apr versions #ifdef'd for your platform.

Have you looked at the old ebcdic branch?
http://svn.apache.org/viewvc/subversion/branches/ebcdic/?r=876004
You might want to try to get a diff of the work done on that branch
relative to its origin, to see what people did back then to make
Subversion deal with ebcdic.

(Note that all I know about EBCDIC is what I read on wikipedia just
a minute ago -- but it sounds like you're in for a lot of fun...)

Stefan
Received on 2010-05-21 01:23:44 CEST