[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r934627 - in /subversion/trunk: ./ subversion/libsvn_client/patch.c subversion/tests/cmdline/patch_tests.py

From: Stefan Sperling <stsp_at_elego.de>
Date: Fri, 16 Apr 2010 14:39:05 +0200

On Fri, Apr 16, 2010 at 11:38:41AM +0100, Philip Martin wrote:
> Julian Foad <julian.foad_at_wandisco.com> writes:
> > Just write "arr->nelts = 0;" (which is the entire body of
> > apr_array_clear()) and don't introduce an ifdef.

I'm a bit sceptical.
Do we really want to rely on implementation details like
"arr->nelts = 0" in the APR code? We don't even do this in our own code.

> I agree that we don't want #if like that in the main code. Put it in
> one of our private header files if you want to use it.

I can make a private macro or function for this, sure.

Stefan
Received on 2010-04-16 14:39:43 CEST

This is an archived mail posted to the Subversion Dev mailing list.