[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r934627 - in /subversion/trunk: ./ subversion/libsvn_client/patch.c subversion/tests/cmdline/patch_tests.py

From: Hyrum K. Wright <hyrum_wright_at_mail.utexas.edu>
Date: Fri, 16 Apr 2010 10:50:22 -0500

On Fri, Apr 16, 2010 at 7:39 AM, Stefan Sperling <stsp_at_elego.de> wrote:

> On Fri, Apr 16, 2010 at 11:38:41AM +0100, Philip Martin wrote:
> > Julian Foad <julian.foad_at_wandisco.com> writes:
> > > Just write "arr->nelts = 0;" (which is the entire body of
> > > apr_array_clear()) and don't introduce an ifdef.
>
> I'm a bit sceptical.
> Do we really want to rely on implementation details like
> "arr->nelts = 0" in the APR code? We don't even do this in our own code.
>
> > I agree that we don't want #if like that in the main code. Put it in
> > one of our private header files if you want to use it.
>
> I can make a private macro or function for this, sure.
>

This was causing some of the buildbots not to be able to build, so I went
ahead and committed a fix in r934969. Feel free to review/update.

-Hyrum
Received on 2010-04-16 17:50:51 CEST

This is an archived mail posted to the Subversion Dev mailing list.