[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r934627 - in /subversion/trunk: ./ subversion/libsvn_client/patch.c subversion/tests/cmdline/patch_tests.py

From: Philip Martin <philip.martin_at_wandisco.com>
Date: Fri, 16 Apr 2010 13:55:35 +0100

Stefan Sperling <stsp_at_elego.de> writes:

> On Fri, Apr 16, 2010 at 11:38:41AM +0100, Philip Martin wrote:
>> Julian Foad <julian.foad_at_wandisco.com> writes:
>> > Just write "arr->nelts = 0;" (which is the entire body of
>> > apr_array_clear()) and don't introduce an ifdef.
>
> I'm a bit sceptical.
> Do we really want to rely on implementation details like
> "arr->nelts = 0" in the APR code?

Two examples where we already set nelts:

$ grep nelts\ =[^=] ../src/subversion/libsvn_*/*c
../src/subversion/libsvn_fs_base/dag.c: copy_ids->nelts = i_out;
../src/subversion/libsvn_fs_fs/caching.c: manifest->nelts = data_len / sizeof(apr_off_t);

-- 
Philip
Received on 2010-04-16 14:56:11 CEST

This is an archived mail posted to the Subversion Dev mailing list.