[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r921848 - /subversion/trunk/subversion/libsvn_wc/adm_ops.c

From: neels <neeels_at_gmail.com>
Date: Fri, 12 Mar 2010 14:15:45 +0100

On 12 March 2010 04:11, Neels J Hofmeyr <neels_at_elego.de> wrote:
> Greg Stein wrote:
>>> +  else
>>> +  if (status == svn_wc__db_status_base_deleted)
>>
>> Woah. This formatting is incorrect. We always do "else if (...". The

So I've grep'd around for else(\n)if occurences.
Notably I'm the only one that lined up the 'if' with the 'else'. All
other occurences indent the 'if'.

hyrum, gstein, would you be fine with me adopting the indented-if
variant? It pleases my eyes *slightly* more. Feel free to say "nah,
come on, just use 'else if' and done".

lundblad(r24045)
subversion/libsvn_client/merge.c:1425: else
subversion/libsvn_client/merge.c-1426- if (prop_state)

--
hwright(r26317) / sussman(r3908)
subversion/svn/propset-cmd.c:91:  else
subversion/svn/propset-cmd.c-92-    if (opt_state->encoding)
--
kfogel(r5500) / julianfoad (r31978)
subversion/svnlook/main.c:1755:      else
subversion/svnlook/main.c-1756-        if (xml)
--
neelsr(921848)
subversion/libsvn_wc/adm_ops.c:2231:  else
subversion/libsvn_wc/adm_ops.c-2232-  if (status ==
svn_wc__db_status_not_present)
--
neels(r906110)
subversion/libsvn_wc/update_editor.c:1775:  else
subversion/libsvn_wc/update_editor.c-1776-  if (reason ==
svn_wc_conflict_reason_added)
subversion/libsvn_wc/update_editor.c:1861:        else
subversion/libsvn_wc/update_editor.c-1862-        if (base_kind ==
svn_wc__db_kind_dir)
--
gstein(r35917) / rhuijben(r39084)
subversion/libsvn_wc/old-and-busted.c:197:      else
subversion/libsvn_wc/old-and-busted.c-198-        if (!
svn_uri_is_canonical(*result, pool))
--
kfogel(r31614)
subversion/tests/libsvn_repos/repos-test.c:2155:  else
subversion/tests/libsvn_repos/repos-test.c-2156-    if
(strcmp(prop_key, SVN_PROP_REVISION_LOG) != 0)
subversion/tests/libsvn_repos/repos-test.c:2216:  else
subversion/tests/libsvn_repos/repos-test.c-2217-    if (err->apr_err
!= SVN_ERR_BAD_PROPERTY_VALUE)
subversion/tests/libsvn_repos/repos-test.c:2236:  else
subversion/tests/libsvn_repos/repos-test.c-2237-    if (err->apr_err
!= SVN_ERR_BAD_PROPERTY_VALUE)
~Neels
Received on 2010-03-12 14:16:18 CET

This is an archived mail posted to the Subversion Dev mailing list.