[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r921848 - /subversion/trunk/subversion/libsvn_wc/adm_ops.c

From: Greg Stein <gstein_at_gmail.com>
Date: Fri, 12 Mar 2010 09:07:01 -0500

On Fri, Mar 12, 2010 at 08:15, neels <neeels_at_gmail.com> wrote:
> On 12 March 2010 04:11, Neels J Hofmeyr <neels_at_elego.de> wrote:
>> Greg Stein wrote:
>>>> +  else
>>>> +  if (status == svn_wc__db_status_base_deleted)
>>>
>>> Woah. This formatting is incorrect. We always do "else if (...". The
>
> So I've grep'd around for else(\n)if occurences.
> Notably I'm the only one that lined up the 'if' with the 'else'. All
> other occurences indent the 'if'.
>
> hyrum, gstein, would you be fine with me adopting the indented-if
> variant? It pleases my eyes *slightly* more. Feel free to say "nah,
> come on, just use 'else if' and done".

You found 10 occurrences of else\n if.

I found 1239 occurrences of else if.

Guess my answer :-)

Cheers,
-g
Received on 2010-03-12 15:07:33 CET

This is an archived mail posted to the Subversion Dev mailing list.