[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r921848 - /subversion/trunk/subversion/libsvn_wc/adm_ops.c

From: Neels J Hofmeyr <neels_at_elego.de>
Date: Fri, 12 Mar 2010 04:11:18 +0100

Greg Stein wrote:
> On Thu, Mar 11, 2010 at 08:52, <neels_at_apache.org> wrote:
>> ...
>> +++ subversion/trunk/subversion/libsvn_wc/adm_ops.c Thu Mar 11 13:52:15 2010
>> ...
>> @@ -2219,9 +2229,32 @@ svn_wc__get_pristine_contents(svn_stream
>> return SVN_NO_ERROR;
>> }
>> }
>> + else
>> + if (status == svn_wc__db_status_base_deleted)
>
> Woah. This formatting is incorrect. We always do "else if (...". The
> code above almost makes it look like the "if" is totally separate
> since it is at the same indentation level, but it ISN'T. The else
> dramatically changes the meaning.
>
> The above style is used nowhere else in our code. Please fix the
> several uses in this function.

Hm, I've used this before, always have.
IMHO it looks much better this way, and is easier to edit around...
I do take care to have the 'else' in the line just above 'if'.

But whatever, if Greg is surprised by it, not many people will be using my
way. Will fix, but now it's high time for bed.

~Neels

Received on 2010-03-12 04:11:58 CET

This is an archived mail posted to the Subversion Dev mailing list.