[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r921848 - /subversion/trunk/subversion/libsvn_wc/adm_ops.c

From: Greg Stein <gstein_at_gmail.com>
Date: Thu, 11 Mar 2010 14:42:57 -0500

On Thu, Mar 11, 2010 at 08:52, <neels_at_apache.org> wrote:
>...
> +++ subversion/trunk/subversion/libsvn_wc/adm_ops.c Thu Mar 11 13:52:15 2010
>...
> @@ -2219,9 +2229,32 @@ svn_wc__get_pristine_contents(svn_stream
>           return SVN_NO_ERROR;
>         }
>     }
> +  else
> +  if (status == svn_wc__db_status_base_deleted)

Woah. This formatting is incorrect. We always do "else if (...". The
code above almost makes it look like the "if" is totally separate
since it is at the same indentation level, but it ISN'T. The else
dramatically changes the meaning.

The above style is used nowhere else in our code. Please fix the
several uses in this function.

>...

Cheers,
-g
Received on 2010-03-11 20:44:31 CET

This is an archived mail posted to the Subversion Dev mailing list.