[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix a deprecation warning.

From: Julian Foad <julian.foad_at_wandisco.com>
Date: Thu, 12 Nov 2009 11:01:10 +0000

On Wed, 2009-11-11, Kannan wrote:
> Stefan Sperling wrote:
> > Thanks. There are still more test failures caused by this patch.
> > Please run all tests and make sure they pass. You can run 'make check'
> > in the working copy root to run all tests, and it will tell you which
> > tests are failing.
>
> Should've run `make check` rather than testing info tests alone, sorry
> for that. Two tests(basic_tests.py 26 and changelist_tests.py 4) failed
> expecting relative paths for info, which is fixed with this patch to
> expect absolute ones. Make check passes.
>
> [[[
> Updated Log:
> Resolve a deprecation warning.

Hold on a minute... This doesn't just resolve a deprecation warning, it
also changes the command-line output format. The log message should say
so.

We try hard not to change the output format. Why do we need to change it
here? The other subcommands manage to convert abs paths back to rel
paths for display.

- Julian

> * subversion/svn/info-cmd.c
> (svn_cl__info): Make the path as absolute and pass to the
> new `svn_client_info3()' and update the receiver type to
> `svn_info_receiver2_t'.
>
> * subversion/libsvn_client/info.c
> (svn_client_info3, push_dir_info,
> crawl_entries, found_entry_baton): Update the receiver type to
> `svn_info_receiver2_t'.
>
> [in subversion/tests/cmdline]:
>
> * info-tests.py
> (info_on_added_file, info_on_mkdir): Expect absolute paths for `svn
> info'.
>
> * basic_tests.py
> (basic_info): Same.
>
> * changelist_tests.py
> (info_with_changelists): Same.
>
> ]]]

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2416970
Received on 2009-11-12 12:01:41 CET

This is an archived mail posted to the Subversion Dev mailing list.