Re: [PATCH] Replace svn_path_join() in svn/diff-cmd.c

Daniel Näslund wrote:
> [[[
> Replace deprecated svn_path_join().
>
> * subversion/svn/cl.h
> (svn_cl__path_join): New.
>
> * subversion/svn/util.c
> (svn_cl__path_join): Wrap svn_path_join().
>
> * subversion/svn/diff-cmd.c
> (svn_cl__diff): Replace svn_path_join() with svn_cl__path_join() since
> the resulting path is allowed to be both uri and dirent.
> (summarize_xml, summarize_regular): Replace svn_path_join() with
> svn_uri_join(). Summarized diffs can only be performed between
> repos.

No, these need to use the new __path_join too. The doc string of summarize_xml() says the path is "either the path to the working copy root or the url ...". The same must apply to summarize_regular(), although it is not explicitly documented.

I think the summarize feature only works with things in the repository (which must of course have a URL), but they can be specified on the command line as local paths with revision numbers ('my/dir_at_1000'). (Anyway, we want to complete the summarize feature one day so that it works with any targets, just like the normal diff.)

- Julian

> Patch by: Daniel Näslund
> Suggested by: julianf
> ]]]
>
> svn_cl__path_join() is there to gather the cases that could not be
> resolved.
>
> /Daniel

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2416952
Received on 2009-11-12 11:15:43 CET