[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix a deprecation warning.

From: Kannan <kannanr_at_collab.net>
Date: Wed, 11 Nov 2009 20:40:26 +0530

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Stefan Sperling wrote:
> Thanks. There are still more test failures caused by this patch.
> Please run all tests and make sure they pass. You can run 'make check'
> in the working copy root to run all tests, and it will tell you which
> tests are failing.

Should've run `make check` rather than testing info tests alone, sorry
for that. Two tests(basic_tests.py 26 and changelist_tests.py 4) failed
expecting relative paths for info, which is fixed with this patch to
expect absolute ones. Make check passes.

[[[
Updated Log:
Resolve a deprecation warning.

* subversion/svn/info-cmd.c
 (svn_cl__info): Make the path as absolute and pass to the
  new `svn_client_info3()' and update the receiver type to
 `svn_info_receiver2_t'.

* subversion/libsvn_client/info.c
 (svn_client_info3, push_dir_info,
  crawl_entries, found_entry_baton): Update the receiver type to
 `svn_info_receiver2_t'.

 [in subversion/tests/cmdline]:

* info-tests.py
 (info_on_added_file, info_on_mkdir): Expect absolute paths for `svn
  info'.

* basic_tests.py
 (basic_info): Same.

* changelist_tests.py
 (info_with_changelists): Same.

]]]

>> Index: ../../../../subversion/svn/info-cmd.c
>> ===================================================================
>> --- ../../../../subversion/svn/info-cmd.c (revision 40430)
>> +++ ../../../../subversion/svn/info-cmd.c (working copy)
>
> Please don't send patches containing paths like this in the future,
> they are a bit combersome to apply.
> Just run 'svn diff' from the root of your svn trunk working copy,
> that's a bit easier for people consuming the patch (because they
> don't need to count how many path components to strip).

Thank you for pointing out, I'll follow hereafter.

- --
Thanks & Regards,
Kannan
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEVAwUBSvrT4XlTqcY7ytmIAQJu8Qf/YpocOAHaNcGJqLotSNHZx+Slp8/LnWUF
gI/5Je82vhQ5kVfsnvaMSKYkfiA9awG2t/fNWiZ9ISGn+fis1AzYXpQ7WuEjNrBs
0BLDb9qvFNhy/AmLSBlMJ69KcPYS4sLKYy0UfZFR6iTXW1esaKC2tqV4s4lW205v
npY/BgSG5bygjQB5iWYPQ5XoGkRR+D8ZsytjvgiHbJyHNWj7F0eUIL424/TLBZxI
Tbu14+1zIA1ex3bH+tHI8xplwcV4jIXPAwpbrYfPqOTD8UmrlI9v0SgO+aMtMugY
NdvFUCNed20UBu7xcs1+SzeBmS5C5J58neLPkwUO1hMNlt/bkEQ/4A==
=YctK
-----END PGP SIGNATURE-----

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2416605

Received on 2009-11-11 16:12:57 CET

This is an archived mail posted to the Subversion Dev mailing list.