[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Replace svn_path_join() in svn/diff-cmd.c

From: Daniel Näslund <daniel_at_longitudo.com>
Date: Thu, 12 Nov 2009 20:35:42 +0100

On Thu, Nov 12, 2009 at 10:15:25AM +0000, Julian Foad wrote:
> Daniel Nslund wrote:
Replace deprecated svn_path_join().

* subversion/svn/cl.h
  (svn_cl__path_join): New.

* subversion/svn/util.c
  (svn_cl__path_join): Wrap svn_path_join().

* subversion/svn/diff-cmd.c
  (svn_cl__diff, summarize_xml, summarize_regular): Replace
    svn_path_join() with svn_cl__path_join() since
    the resulting path is allowed to be both uri and dirent.

Patch by: Daniel Nslund <daniel{_AT_}longitudo.com>
Suggested by: julianf

> No, these need to use the new __path_join too. The doc string of
> summarize_xml() says the path is "either the path to the working copy
> root or the url ...". The same must apply to summarize_regular(),
> although it is not explicitly documented.

Somehow I read somewhere that summarize stuff could only use repos when
it was stated just above the functions I was changing that the paths
could be either sort!

make check passed.


Received on 2009-11-12 20:36:00 CET

This is an archived mail posted to the Subversion Dev mailing list.