On Mon, Nov 09, 2009 at 03:34:18PM +0530, Kannan wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Stefan Sperling wrote:
> > It's not clear to me yet how we're going to translate absolute paths
> > to relative paths in all cases.
> >
> > I think for now it's fine to adjust the tests to expect absolute paths.
> > See patch_unidiff_absolute_paths in patch_tests.py for an example of
> > how we can deal with absolute paths in tests.
>
> Thank you Stefan. As per your comments, updated the tests to expect
> absolute paths and they pass now. Attaching the updated patch herewith.
Thanks. There are still more test failures caused by this patch.
Please run all tests and make sure they pass. You can run 'make check'
in the working copy root to run all tests, and it will tell you which
tests are failing.
> Index: ../../../../subversion/svn/info-cmd.c
> ===================================================================
> --- ../../../../subversion/svn/info-cmd.c (revision 40430)
> +++ ../../../../subversion/svn/info-cmd.c (working copy)
Please don't send patches containing paths like this in the future,
they are a bit combersome to apply.
Just run 'svn diff' from the root of your svn trunk working copy,
that's a bit easier for people consuming the patch (because they
don't need to count how many path components to strip).
Stefan
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2416169
Received on 2009-11-10 15:49:12 CET