[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix a deprecation warning.

From: Stefan Sperling <stsp_at_elego.de>
Date: Thu, 5 Nov 2009 13:58:38 +0100

On Tue, Nov 03, 2009 at 10:10:50PM +0530, Kannan wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> > Stefan Sperling wrote:
> >> On Mon, Oct 26, 2009 at 07:25:35PM +0530, Kannan wrote:
> >>> -----BEGIN PGP SIGNED MESSAGE-----
> >>> Hash: SHA1
> >>>
> >>>
> >>> Log:
> >>> Resolve a deprecation warning.
> >>>
> >>> * subversion/svn/info-cmd.c
> >>> (svn_cl__info): Use `svn_client_info3()'.
> >>>
> >>> Patch by: Kannan R <kannanr_at_collab.net>
> >
> >>> Index: subversion/svn/info-cmd.c
> >>> ===================================================================
> >>> --- subversion/svn/info-cmd.c (revision 40224)
> >>> +++ subversion/svn/info-cmd.c (working copy)
> >>> @@ -527,7 +527,7 @@
> >>> && (peg_revision.kind == svn_opt_revision_unspecified))
> >>> peg_revision.kind = svn_opt_revision_head;
> >>>
> >>> - err = svn_client_info2(truepath,
> >>> + err = svn_client_info3(truepath,
> >>> &peg_revision, &(opt_state->start_revision),
> >>> receiver, NULL, opt_state->depth,
> >>> opt_state->changelists, ctx, subpool);
> >> Are you sure you don't need to update the receiver also?
> >
> >> svn_client_info2's docstring says:
> >
> >> /** Similar to svn_client_info3, but uses an svn_info_receiver_t instead of
> >> * a svn_info_receiver2_t.
> >
> > Thank you stsp. After your comments in IRC, changed the receiver type to
> > `svn_info_receiver2_t' and passed the path as absolute to
> > `svn_client_info3()' as it expects an 'abspath_or_url', also to avoid an
> > assertion failed error in `svn_wc__db_read_info()' and just tested `svn
> > info'. It runs fine, before I could change anything in `print_info()'.
> > I'm attaching the patch herewith. Please correct me if I'm wrong.
> >
>
> Any updates on this thread?

Sorry, this got lost.

I've just tested your patch. It changes output -- svn info shows
absolute paths instead of relative paths. This in itself is not
a huge problem, we know that it happens as part of the wc-ng transition,
and we may have to figure out a way to make absolute paths relative
for command line client output if possible.

But the problem is that the changed output breaks tests.
I've only tested info_tests with your patch, and info tests 2 and 3
are failing. Please run all tests and make sure they pass before sending
patches. If you cannot get a test to pass, mention this in your patch
submission and ask for help. It's important to run *all* tests on a
patch, because breakage sometimes shows up in unexpected places. This
is quite time consuming but necessary.

Stefan

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2414699
Received on 2009-11-05 13:59:00 CET

This is an archived mail posted to the Subversion Dev mailing list.