[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix a deprecation warning.

From: Kannan <kannanr_at_collab.net>
Date: Fri, 06 Nov 2009 12:59:02 +0530

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Stefan Sperling wrote:
> Sorry, this got lost.
>
> I've just tested your patch. It changes output -- svn info shows
> absolute paths instead of relative paths. This in itself is not
> a huge problem, we know that it happens as part of the wc-ng transition,
> and we may have to figure out a way to make absolute paths relative
> for command line client output if possible.
>
> But the problem is that the changed output breaks tests.
> I've only tested info_tests with your patch, and info tests 2 and 3
> are failing. Please run all tests and make sure they pass before sending
> patches. If you cannot get a test to pass, mention this in your patch
> submission and ask for help. It's important to run *all* tests on a
> patch, because breakage sometimes shows up in unexpected places. This
> is quite time consuming but necessary.

Thank you for the comments Stefan. I could see the info tests 2 and 3
fail, as the path returned is an absolute one. Should we make a
transition again to relative paths for the output?

- --
Thanks & Regards,
Kannan
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEVAwUBSvPQPnlTqcY7ytmIAQLfBgf/TVbgMFL/dt45WD4K4aZ4gOZqMAznyveu
gsPczy6mucAbZZi6gGgbu1WNhsYfMANVgmvujLhcsWi8zm9qtcq6PNdXSyC4aw2D
iX5FhXwJAoZnRK7Kigg0bYwKsGb6WT7WmCY1mZRVb+Z71h/GGe0h80MUBP9PuqbL
TAftSZqkjLcz2Mo2Zs3jK9Mk+vZDyuqgG0yOPW3qKIg7P7vtUx1x1LFyv7yZYJ+U
Lfua6hDwaCEIcpwl7+E2S4vJZmlhpEdkuPf8MQtrDRotFarLpR64nxeX+/MDm/B4
IBPRSRErEaPVBd+UgB1p9MmoKdkJBiwD3WSZxkpOiwOQwd1dg543qg==
=gvRC
-----END PGP SIGNATURE-----

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2415007

Received on 2009-11-06 08:31:10 CET

This is an archived mail posted to the Subversion Dev mailing list.