[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix a deprecation warning.

From: Kannan <kannanr_at_collab.net>
Date: Tue, 03 Nov 2009 22:10:50 +0530

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

> Stefan Sperling wrote:
>> On Mon, Oct 26, 2009 at 07:25:35PM +0530, Kannan wrote:
>>> -----BEGIN PGP SIGNED MESSAGE-----
>>> Hash: SHA1
>>>
>>>
>>> Log:
>>> Resolve a deprecation warning.
>>>
>>> * subversion/svn/info-cmd.c
>>> (svn_cl__info): Use `svn_client_info3()'.
>>>
>>> Patch by: Kannan R <kannanr_at_collab.net>
>
>>> Index: subversion/svn/info-cmd.c
>>> ===================================================================
>>> --- subversion/svn/info-cmd.c (revision 40224)
>>> +++ subversion/svn/info-cmd.c (working copy)
>>> @@ -527,7 +527,7 @@
>>> && (peg_revision.kind == svn_opt_revision_unspecified))
>>> peg_revision.kind = svn_opt_revision_head;
>>>
>>> - err = svn_client_info2(truepath,
>>> + err = svn_client_info3(truepath,
>>> &peg_revision, &(opt_state->start_revision),
>>> receiver, NULL, opt_state->depth,
>>> opt_state->changelists, ctx, subpool);
>> Are you sure you don't need to update the receiver also?
>
>> svn_client_info2's docstring says:
>
>> /** Similar to svn_client_info3, but uses an svn_info_receiver_t instead of
>> * a svn_info_receiver2_t.
>
> Thank you stsp. After your comments in IRC, changed the receiver type to
> `svn_info_receiver2_t' and passed the path as absolute to
> `svn_client_info3()' as it expects an 'abspath_or_url', also to avoid an
> assertion failed error in `svn_wc__db_read_info()' and just tested `svn
> info'. It runs fine, before I could change anything in `print_info()'.
> I'm attaching the patch herewith. Please correct me if I'm wrong.
>

Any updates on this thread?

- --
Regards,
Kannan
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEVAwUBSvBdEnlTqcY7ytmIAQI5Nwf/TSTNoY6CKR+1J7xSmCHRt26/vv6pp47G
oN12I7/hTxkv3KDeFnv0UZzvU5Za7x++DSYvhA9q/Kuw5jBRk1231xvq0IEe9nS7
CHFtsmhq4E9Od1CfPmeu3ptD/rBUX0aoeIsA9nnFWsff6w8HUxdAxVwhP00RAYLw
+Az89ITzEp3m4K+P/aDS9sjkl5CNnDUycmO6tlSvjO0/LarJ8s61b/bj6ZIG35Jo
MnCtmSAqedobPq/zYE6eQgMi5pQPodCOPi1NDoLeL8CkHqC7Wk5w98yt5LqKuB75
AQsqc3KbNKpxS11hIBkF6tj6ror3qBwkhPdK6QS6p5ALzBxSaJXpMw==
=tomn
-----END PGP SIGNATURE-----

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2414153

Received on 2009-11-03 17:42:18 CET

This is an archived mail posted to the Subversion Dev mailing list.