[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] Remove 'svnver' array warning in svndiff.c when

From: Edmund Wong <ed_at_kdtc.net>
Date: Thu, 5 Nov 2009 00:39:29 +0800


During a Windows compile under VS2008, the following warning is shown:

..\..\..\subversion\libsvn_delta\svndiff.c(193): warning C4295: 'svnver' :
array is too small to include a terminating null character



This patch fixes this misleading assignment. As per notes/svndiff (thanks
danielsh), svnver = 'SVN\0' where \0 is the format #. The compiler doesn't
know that and thinks the code is trying to insert another NULL.

* subversion\libsvn_delta\svndiff.c
  window_handler: Changed "SVN\0" to {'S','V','N',0}.

Patch by: Edmund Wong <ed{_AT_}kdtc.net>
Suggested by: rhuijben



Received on 2009-11-04 17:38:01 CET

This is an archived mail posted to the Subversion Dev mailing list.