Re: [PATCH] Remove 'svnver' array warning in svndiff.c when

Edmund Wong wrote:
> Hi,
>
> During a Windows compile under VS2008, the following warning is shown:
>
> ..\..\..\subversion\libsvn_delta\svndiff.c(193): warning C4295: 'svnver' :
> array is too small to include a terminating null character
>
> Log:
>
> [[[
>
> This patch fixes this misleading assignment. As per notes/svndiff (thanks
> danielsh), svnver = 'SVN\0' where \0 is the format #. The compiler doesn't
> know that and thinks the code is trying to insert another NULL.
>
> * subversion\libsvn_delta\svndiff.c
> window_handler: Changed "SVN\0" to {'S','V','N',0}.
>
> Patch by: Edmund Wong <ed{_AT_}kdtc.net>
> Suggested by: rhuijben
>

Hmmm ... That shouldn't be a warning, but on the other hand, using
{"SVN\0"} is just as correct, and easier to read.

Also please use forward slashes for path separators in the log message.

-- Brane

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2414469
Received on 2009-11-04 18:16:30 CET