[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Junit report for Subversion tests

From: Bhuvaneswaran A <bhuvan_at_collab.net>
Date: Mon, 26 Oct 2009 16:14:05 +0530

On Thu, 2009-10-22 at 14:11 -0500, Hyrum K. Wright wrote:
>
> That does seem rather quick. I just ran 'make check' on a separate
> working copy on the same machine, and got something different:
> real 32m51.756s
> user 6m40.321s
> sys 6m27.504s
>
> I don't know that this is a problem with the junit converter script,
> or perhaps the test running reporting bogus ELAPSED times.

This seem to be a problem with combination of both scripts. As there is
no way to calculate the time taken for EACH TEST, we calculate it based
on total time taken. However it is not done correctly.

For instance, consider a test suite that has 10 tests taking 15 seconds
to complete. We don't know the time taken for 10 tests individually. We
only know that it took 15 seconds for all 10 tests together. We
calculate the time taken for individual tests as 1 instead of 1.5. It's
due to a bug in gen_junit_report.py script.

On the other hand, since we do not account for milliseconds, those tests
are recorded as 0 ms for individual tests.

The Hudson as such, does not recognise the time specified for each test
suite in the junit report. Instead it calculates the time taken for each
test suite based on time taken for each test individually. Due to this
bug, in the above use case, the Hudson would report 10 seconds, because
according to the junit report, each test has taken 1 second.

Bottom line, I see two issues to be fixed here:
  a) Include milliseconds in the tests log file, tests.log.
  b) Do not round the result while calculating the time taken for each
     test.

Attached a patch for issue {a} in another thread.

> Another problem: on some of the test information pages, I see stuff
> like:
> lock_tests-py.lock_tests.py 1: lock a file and verify that it&apos;s
> locked
> The html entity looks a bit out-of-place.

We do escape the xml entities {<,>,',",&}. They seem to work well with
the test names when they are displayed in the report. In the final
screen where we see the status of the test, it does not play along well.
I'll see to fix this.

Thank you.

-- 
Bhuvaneswaran A    
CollabNet Software P Ltd.  |  www.collab.net
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2411335

Received on 2009-10-26 11:44:28 CET

This is an archived mail posted to the Subversion Dev mailing list.