[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix some deprecation warnings

From: Kannan <kannanr_at_collab.net>
Date: Fri, 23 Oct 2009 17:43:59 +0530

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Branko ─îibej wrote:
> Kannan wrote:
>> Log:
>> Resolve some deprecation warnings and a bit of formatting.
>>
>> * subversion/libsvn_subr/target.c
>> (svn_path_condense_targets): Use `svn_dirent_get_absolute()',
>> `svn_dirent_get_longest_ancestor()' and `svn_dirent_is_root()'.
>> (svn_path_remove_redundancies): Use `svn_dirent_get_absolute()' and
>> `svn_dirent_is_child()'.
>>
>> Patch by: Kannan R <kannanr_at_collab.net>
>>
>> @@ -121,8 +121,8 @@
>> abs_targets_i = APR_ARRAY_IDX(abs_targets, i, const char *);
>> abs_targets_j = APR_ARRAY_IDX(abs_targets, j, const char *);
>> - ancestor = svn_path_get_longest_ancestor
>> - (abs_targets_i, abs_targets_j, pool);
>> + ancestor = svn_dirent_get_longest_ancestor
>> + (abs_targets_i, abs_targets_j, pool);
>> if (*ancestor == '\0')
>> continue;
>
> I'm curious -- why this change? The original indentation looks correct,
> although I would have expected the opening parenthesis to be at the end
> of the previous line.
>
> -- Brane

Oops, that wasn't my intention. Might've been due to some mishap with
the keyboard.

- --
Regards,
Kannan
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEVAwUBSuGeBnlTqcY7ytmIAQLIlgf/TVjuS9NS/eVin1IKGZXRKOug/E8+RDUf
vYMQh01K/RqsYQ6gG7VFU3dxaL/YJHJWKF7ykwkJ0C/zQmmSqO0ml6QHfzf2luVP
M9sMv6Svy8TazGzmnD1kuZdOBW4APNPTICnwALfrN82NhNi0nGk/aANDHiAACcQy
KDi1mme4If+Xph5ke9nPlNWWEbh79wxF2NNyNKIRxYdxgHmaGUxb9G62qQ99iVp0
bZZaOxyq/QxNRiRekvgAwaUBSv8v7mhXRwfXcYIStnZQ++qSry6zdcq6Yof5nulU
ZEpnbAZgbBf5sod6jG1amB+EoOxgcuv7b+EdPblhUlgsG6CBpl7b+g==
=pUr/
-----END PGP SIGNATURE-----

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2410626

Received on 2009-10-23 14:15:00 CEST

This is an archived mail posted to the Subversion Dev mailing list.