[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix some deprecation warnings

From: Branko Cibej <brane_at_xbc.nu>
Date: Fri, 23 Oct 2009 14:09:01 +0200

Kannan wrote:
> Log:
> Resolve some deprecation warnings and a bit of formatting.
>
> * subversion/libsvn_subr/target.c
> (svn_path_condense_targets): Use `svn_dirent_get_absolute()',
> `svn_dirent_get_longest_ancestor()' and `svn_dirent_is_root()'.
> (svn_path_remove_redundancies): Use `svn_dirent_get_absolute()' and
> `svn_dirent_is_child()'.
>
> Patch by: Kannan R <kannanr_at_collab.net>
>
> @@ -121,8 +121,8 @@
> abs_targets_i = APR_ARRAY_IDX(abs_targets, i, const char *);
> abs_targets_j = APR_ARRAY_IDX(abs_targets, j, const char *);
> - ancestor = svn_path_get_longest_ancestor
> - (abs_targets_i, abs_targets_j, pool);
> + ancestor = svn_dirent_get_longest_ancestor
> + (abs_targets_i, abs_targets_j, pool);
> if (*ancestor == '\0')
> continue;

I'm curious -- why this change? The original indentation looks correct,
although I would have expected the opening parenthesis to be at the end
of the previous line.

-- Brane

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2410623
Received on 2009-10-23 14:09:19 CEST

This is an archived mail posted to the Subversion Dev mailing list.