[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Request to fix the Ruby bindings build for windows [was:Re: [Patch] Make Ruby and Perl shared libraries .dll again]

From: Joe Swatosh <joe.swatosh_at_gmail.com>
Date: Wed, 21 Oct 2009 07:43:59 -0700

On Wed, Jun 3, 2009 at 8:25 PM, Joe Swatosh <joe.swatosh_at_gmail.com> wrote:
> On Fri, May 29, 2009 at 3:56 AM, Stefan Sperling <stsp_at_elego.de> wrote:
>> On Thu, May 28, 2009 at 10:23:54PM -0700, Joe Swatosh wrote:
>>> This is not part of the Ruby bindings so it is not for me to commit
>>> without approval by a full committer. Is the patch acceptable with the
>>> log message amended below?
>>>
>>> --
>>> Joe
>>>
>>> [[[
>>>
>>> Partially revert r37331 "On Windows, shared libs for Python bindings
>>> should be *.pyd not *.dll."  In addition to changing the shared libs for
>>> the Python bindings, r37331 inadvertently changed the extensions of the
>>> shared libraries produced for the Perl and Ruby bindings from .dll to
>>> .pyd.  Change the extensions back to .dll for the Ruby and Perl
>>> bindings.
>>>
>>> * build/generator/gen_base.py (TargetSWIG.add_dependencies): Mark Python
>>>   wrapper shared libs as type "pyd" not "lib".
>>>
>>> ]]]
>>>
>>> ===================================================================
>>> --- build/generator/gen_base.py (revision 37787)
>>> +++ build/generator/gen_base.py (working copy)
>>> @@ -550,12 +550,13 @@
>>>     # Extract SWIG module name from .i file name
>>>     module_name = iname[:4] != 'svn_' and iname[:-2] or iname[4:-2]
>>>
>>> -    lib_extension = self.gen_obj._extension_map['pyd', 'target']
>>> +    lib_extension = self.gen_obj._extension_map['lib', 'target']
>>>     if self.lang == "ruby":
>>>       lib_filename = module_name + lib_extension
>>>     elif self.lang == "perl":
>>>       lib_filename = '_' + module_name.capitalize() + lib_extension
>>>     else:
>>> +      lib_extension = self.gen_obj._extension_map['pyd', 'target']
>>

>>
>

>
>

Would some build system expert please fix the generation of the extensions for
the Ruby bindings on windows? r37331 changed the extensions for all the swig
based bindings from .dll to .pyd. (According to Brane, .pyd is the shared-
object extension used by Python). Since this change I have been
unable to build
the Ruby bindings without modifying trunk. I suspect the Perl bindings are in
the same situation.

Thanks very much,

--
Joe
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2409801
Received on 2009-10-21 16:44:12 CEST

This is an archived mail posted to the Subversion Dev mailing list.