[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r40008 - trunk/subversion/mod_dav_svn

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: Wed, 14 Oct 2009 08:54:50 -0400

Senthil Kumaran S wrote:
> Author: stylesen
> Date: Wed Oct 14 01:52:15 2009
> New Revision: 40008

[...]

> Modified: trunk/subversion/mod_dav_svn/repos.c
> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/mod_dav_svn/repos.c?pathrev=40008&r1=40007&r2=40008
> ==============================================================================
> --- trunk/subversion/mod_dav_svn/repos.c Wed Oct 14 00:47:26 2009 (r40007)
> +++ trunk/subversion/mod_dav_svn/repos.c Wed Oct 14 01:52:15 2009 (r40008)
> @@ -3374,12 +3374,17 @@ deliver(const dav_resource *resource, ap
>
> svn_pool_destroy(entry_pool);
>
> - if (gen_html)
> - ap_fputs(output, bb,
> - " </ul>\n <hr noshade><em>Powered by "
> - "<a href=\"http://subversion.tigris.org/\">Subversion</a> "
> - "version " SVN_VERSION "."
> - "</em>\n</body></html>");
> + if (gen_html
> + && (strcmp(ap_psignature("FOO", resource->info->r), "") != 0))
> + {
> + /* Apache's signature generation code didn't eat our prefix.
> + ServerSignature must be enabled. Print our version info. */

Please add something like this to the comment above:

  WARNING: This is a kludge!! ap_psignature() doesn't promise to return
  the empty string when ServerSignature is off. We know it does by code
  inspection, but this behavior is subject to change. (Perhaps we should
  try to get the Apache folks to make this promise, though...)

-- 
C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2407528

Received on 2009-10-14 14:55:21 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.