[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: svn commit: r40008 - trunk/subversion/mod_dav_svn

From: Mark Phippard <markphip_at_gmail.com>
Date: Wed, 14 Oct 2009 05:16:18 -0700 (PDT)

> - if (gen_html)
> - ap_fputs(output, bb,
> - " </ul>\n <hr noshade><em>Powered by "
> - "<a href=\"http://subversion.tigris.org/\">Subversion</a> "
> - "version " SVN_VERSION "."
> - "</em>\n</body></html>");
> + if (gen_html
> + && (strcmp(ap_psignature("FOO", resource->info->r), "") != 0))
> + {
> + /* Apache's signature generation code didn't eat our prefix.
> + ServerSignature must be enabled. Print our version info. */
> + ap_fputs(output, bb,
> + " </ul>\n <hr noshade><em>Powered by "
> + "<a href=\"http://subversion.tigris.org/\">Subversion</a> "
> + "version " SVN_VERSION "."
> + "</em>\n</body></html>");
> + }
> else
> ap_fputs(output, bb, " </index>\n</svn>\n");

I do not really understand what that check is doing related to FOO, but I trust it is right. That said, the change itself is not right. It is suppressing the closing </body> and </html> tags, which means the page will be invalid HTML. It should only be supressing the "Powered by Subversion version X.Y.Z" line.

Mark

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2407512
Received on 2009-10-14 14:16:29 CEST

This is an archived mail posted to the Subversion Dev mailing list.