[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: svn commit: r39926 - trunk

From: Bert Huijben <rhuijben_at_sharpsvn.net>
Date: Sat, 10 Oct 2009 19:26:13 +0200

> -----Original Message-----
> From: Daniel Shahaf [mailto:d.s_at_daniel.shahaf.name]
> Sent: zaterdag 10 oktober 2009 19:15
> To: Bert Huijben
> Cc: dev_at_subversion.tigris.org; svn_at_subversion.tigris.org
> Subject: RE: svn commit: r39926 - trunk
>
> Bert Huijben wrote on Sat, 10 Oct 2009 at 18:51 +0200:
> > > Fix the Windows build.
> > >
> > > * build.conf (libsvn_subr): Export svn_debug.h.
> >
> > This fixes the Windows shared library build for debug mode, but it
> breaks
> > the Windows build for release mode.. See the buildbots.
> >
>
> Thanks, I haven't noticed they broke.
>
> > libsvn_subr.def : error LNK2001: unresolved external symbol
> > svn_dbg__preamble
> > libsvn_subr.def : error LNK2001: unresolved external symbol
> svn_dbg__printf
> > ..\..\..\Release\subversion\libsvn_subr\libsvn_subr-1.lib : fatal
> error
> > LNK1120: 2 unresolved externals
> >
>
> What do you suggest then? Without this change I get the same error
> when
> I try to use SVN_DBG in debug builds.
>
> Could we just define the svn_dbg__* functions unconditionally? (and
> make them no-ops if SVN_DEBUG is not defined)

I think that would be safe. But we might just define them always as the
macros remove the call sites anyway. (And this would allow using them from a
debug mode application compiled against a release library).

        Bert

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2406015
Received on 2009-10-10 19:28:55 CEST

This is an archived mail posted to the Subversion Dev mailing list.