RE: svn commit: r39926 - trunk

Bert Huijben wrote on Sat, 10 Oct 2009 at 18:51 +0200:
> > Fix the Windows build.
> >
> > * build.conf (libsvn_subr): Export svn_debug.h.
>
> This fixes the Windows shared library build for debug mode, but it breaks
> the Windows build for release mode.. See the buildbots.
>

Thanks, I haven't noticed they broke.

> libsvn_subr.def : error LNK2001: unresolved external symbol
> svn_dbg__preamble
> libsvn_subr.def : error LNK2001: unresolved external symbol svn_dbg__printf
> ..\..\..\Release\subversion\libsvn_subr\libsvn_subr-1.lib : fatal error
> LNK1120: 2 unresolved externals
>

What do you suggest then? Without this change I get the same error when
I try to use SVN_DBG in debug builds.

Could we just define the svn_dbg__* functions unconditionally? (and
make them no-ops if SVN_DEBUG is not defined)

> Bert
>
>

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2405981
Received on 2009-10-10 19:14:53 CEST