[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Fixing issue 3368

From: Stefan Sperling <stsp_at_elego.de>
Date: Tue, 15 Sep 2009 12:59:54 +0100

On Tue, Sep 15, 2009 at 07:39:07AM -0400, Mark Phippard wrote:
> On Tue, Sep 15, 2009 at 6:55 AM, Senthil Kumaran S <senthil_at_collab.net> wrote:
> > Senthil Kumaran S wrote:
> >> Stefan Sperling wrote:
> >>>> +          for (hi = apr_hash_first(subpool, props); hi; hi = apr_hash_next(hi))
> >>>> +            pval = svn_apr_hash_index_val(hi);
> >>> I don't have any comments on what the best way to fix the issue is,
> >>> just one question on the code.
> >>>
> >>> Why are you looping though all properties and test the very last one you end
> >>> up with, instead of testing each property?
> >>
> >> That is just a test. But that does not make sense, my final commit will have
> >> proper checking.
> >
> > Committed a fix in r39329.
>
> Great. Any chance of nominating this for 1.6.x? Or is it too tied up
> with the changes on trunk? A lot of people have complained about this
> bug.

I just took a look at the commit, it's a very simple fix.
Should be straightforward to backport.

Stefan

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2395000
Received on 2009-09-15 14:00:11 CEST

This is an archived mail posted to the Subversion Dev mailing list.