[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Fixing issue 3368

From: Mark Phippard <markphip_at_gmail.com>
Date: Tue, 15 Sep 2009 07:39:07 -0400

On Tue, Sep 15, 2009 at 6:55 AM, Senthil Kumaran S <senthil_at_collab.net> wrote:
> Senthil Kumaran S wrote:
>> Stefan Sperling wrote:
>>>> +          for (hi = apr_hash_first(subpool, props); hi; hi = apr_hash_next(hi))
>>>> +            pval = svn_apr_hash_index_val(hi);
>>> I don't have any comments on what the best way to fix the issue is,
>>> just one question on the code.
>>> Why are you looping though all properties and test the very last one you end
>>> up with, instead of testing each property?
>> That is just a test. But that does not make sense, my final commit will have
>> proper checking.
> Committed a fix in r39329.

Great. Any chance of nominating this for 1.6.x? Or is it too tied up
with the changes on trunk? A lot of people have complained about this

Mark Phippard
Received on 2009-09-15 13:39:17 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.