On Tue, Sep 15, 2009 at 7:59 AM, Stefan Sperling <stsp_at_elego.de> wrote:
> On Tue, Sep 15, 2009 at 07:39:07AM -0400, Mark Phippard wrote:
>> On Tue, Sep 15, 2009 at 6:55 AM, Senthil Kumaran S <senthil_at_collab.net> wrote:
>> > Senthil Kumaran S wrote:
>> >> Stefan Sperling wrote:
>> >>>> + for (hi = apr_hash_first(subpool, props); hi; hi = apr_hash_next(hi))
>> >>>> + pval = svn_apr_hash_index_val(hi);
>> >>> I don't have any comments on what the best way to fix the issue is,
>> >>> just one question on the code.
>> >>> Why are you looping though all properties and test the very last one you end
>> >>> up with, instead of testing each property?
>> >> That is just a test. But that does not make sense, my final commit will have
>> >> proper checking.
>> > Committed a fix in r39329.
>> Great. Any chance of nominating this for 1.6.x? Or is it too tied up
>> with the changes on trunk? A lot of people have complained about this
> I just took a look at the commit, it's a very simple fix.
> Should be straightforward to backport.
Wow, I just looked at the commit too. That took some good digging to
come up with such a simple, but not-obvious, fix.
Nice job Senthil.
Received on 2009-09-15 14:21:17 CEST