[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Fixing issue 3368

From: Senthil Kumaran S <senthil_at_collab.net>
Date: Tue, 15 Sep 2009 16:25:07 +0530

Senthil Kumaran S wrote:
> Stefan Sperling wrote:
>>> + for (hi = apr_hash_first(subpool, props); hi; hi = apr_hash_next(hi))
>>> + pval = svn_apr_hash_index_val(hi);
>> I don't have any comments on what the best way to fix the issue is,
>> just one question on the code.
>>
>> Why are you looping though all properties and test the very last one you end
>> up with, instead of testing each property?
>
> That is just a test. But that does not make sense, my final commit will have
> proper checking.

Committed a fix in r39329.

Thank You.

-- 
Senthil Kumaran S
http://www.stylesen.org/
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2394963
Received on 2009-09-15 12:55:25 CEST

This is an archived mail posted to the Subversion Dev mailing list.