[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Remove po file charset stripping on Windows

From: Roman Donchenko <DXDragon_at_yandex.ru>
Date: Sun, 13 Sep 2009 17:47:36 +0400

Branko Cibej <brane_at_xbc.nu> писал в своём письме Sun, 13 Sep 2009 14:13:57
+0400:

> Roman Donchenko wrote:
>> Meanwhile, I noticed that the Subversion libintl is specifically
>> modified
>> not to link to libiconv, which means it's not going to recode the
>> strings
>> whether bind_textdomain_codeset is called or not. Huh. I still suppose
>> an
>> explicit call won't hurt.
>>
>
>
> I frankly don't understand the point of this discussion. Removing
> codeset definition from the .po files is just an extra safety net that
> prevents the aforementioned bug from raising its head if someone links
> Subversion binaries with a different variant of libintl that does depend
> on libiconv. The only downside I can think of is that it causes msgfmt
> to complain during the build, but those warnings have no adverse side
> effects.

The point is that we can get rid of the warnings and simplify the build
system by removing the stripping,
while still providing the safety net by calling bind_textdomain_codeset().

Roman.

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2394298
Received on 2009-09-13 15:48:13 CEST

This is an archived mail posted to the Subversion Dev mailing list.